Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync with upstream #182

Closed
wants to merge 3 commits into from
Closed

chore: sync with upstream #182

wants to merge 3 commits into from

Conversation

mantrachain-support
Copy link

@mantrachain-support mantrachain-support commented Sep 25, 2024 •
edited by coderabbitai bot
Loading

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a Linux-only backend for key management in the crypto/keyring module, supporting the Linux kernel's keyctl.

  • Bug Fixes

    • Corrected baseapp options ordering to prevent overwriting module-set options.
    • Fixed a regression affecting upgrades beyond v0.50.7.
    • Adjusted halt height behavior in baseapp to restore previous functionality.
    • Ensured PreBlocker events are returned in the FinalizeBlockResponse.

  • Documentation

    • Updated documentation to include details about the new keyctl backend in the crypto/keyring package.

  • Dependency Updates

    • Updated dependencies to reflect new versions for cosmossdk.io/api and cosmossdk.io/client/v2.

julienrbrt and others added 3 commits September 20, 2024 12:56
@julienrbrt
chore: correct date cl v0.50.10 (#21832)
6dc6e8b
@mergify @alessio
@tac0turtle @julienrbrt
feat(crypto/keyring): add Linux's keyctl support (backport #21653) (#…
809950e 
…21840)

Co-authored-by: Alessio Treglia <al@essio.dev>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @akhilkumarpilli @julienrbrt
fix(x/staking): query redelegation command (backport #21856) (#21861)
a5f463a 
Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a new Linux-only backend for the crypto/keyring module, which supports the Linux kernel's keyctl. It also updates the changelog with a new version tag for v0.50.10, detailing several bug fixes and enhancements across various modules, including adjustments to consensus parameters and improvements in the staking query functionality. Additionally, the go.mod files are updated to reflect new dependency versions.

Changes

Files Change Summary
CHANGELOG.md Updated to include a new Linux-only backend feature and several bug fixes.
api/cosmos/staking/v1beta1/query.pulsar.go Modified protocol buffer definitions, adding new fields and updating existing field types.
crypto/keyring/doc.go Added documentation for the new keyctl backend in the crypto/keyring package.
crypto/keyring/keyring.go Removed Options struct; renamed New function to newKeyringGeneric.
crypto/keyring/keyring_linux.go Introduced a new Linux-specific backend for key management with various configuration options.
crypto/keyring/keyring_linux_test.go Added a test suite for the NewKeyctlKeyring function on Linux.
crypto/keyring/keyring_other.go Introduced a package for non-Linux environments with an Options struct and New function.
go.mod Updated cosmossdk.io/api version from v0.7.5 to v0.7.6.
proto/cosmos/staking/v1beta1/query.proto Updated field types in QueryRedelegationsRequest for validator addresses.
simapp/go.mod Updated cosmossdk.io/api and cosmossdk.io/client/v2 versions.
tests/go.mod Updated cosmossdk.io/api and cosmossdk.io/client/v2 versions.
x/staking/autocli.go Updated dst_validator_addr positional argument to be optional.

Possibly related PRs

  • fix: sdk ci bump go and sync with upstream #8: The main PR introduces a new Linux-only backend for the keyctl support in the crypto/keyring module, while the retrieved PR focuses on updating Go-related components and ensuring synchronization with upstream changes, which may indirectly relate to the overall functionality and compatibility of the SDK.

Suggested labels

C:x/upgrade, Type: CI, C:log, C:Simulations

Suggested reviewers

  • mantramatt

Poem

In a meadow so bright, with changes galore,
A Linux keyring hops through the door.
With fixes and updates, the code's in a dance,
Enhancing our cosmos, giving all a chance.
So let’s cheer for the bugs that have fled,
And celebrate progress, as new paths are tread! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mantrachain-support mantrachain-support changed the title Release/v0.50.x chore: sync with upstream Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mantrachain-support @julienrbrt